]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
lgdt330x: fix signedness error in i2c_read_demod_bytes()
authorXi Wang <xi.wang@gmail.com>
Tue, 14 Feb 2012 17:32:41 +0000 (14:32 -0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 2 Apr 2012 16:27:18 +0000 (09:27 -0700)
commit88a782d295e29051e1da10a097ff72b3918dbaa9
treee78a195800a8b3827917e86901640dacdca19f43
parent7d088dca7920bc7c5d74d6c430699abb63ec0151
lgdt330x: fix signedness error in i2c_read_demod_bytes()

commit 34817174fca0c5512c2d5b6ea0fc37a0337ce1d8 upstream.

The error handling in lgdt3303_read_status() and lgdt330x_read_ucblocks()
doesn't work, because i2c_read_demod_bytes() returns a u8 and (err < 0)
is always false.

        err = i2c_read_demod_bytes(state, 0x58, buf, 1);
        if (err < 0)
                return err;

Change the return type of i2c_read_demod_bytes() to int.  Also change
the return value on error to -EIO to make (err < 0) work.

Signed-off-by: Xi Wang <xi.wang@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/media/dvb/frontends/lgdt330x.c