]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
drm/i915/sdvo: clean up connectors on intel_sdvo_init() failures
authorJani Nikula <jani.nikula@intel.com>
Mon, 12 Nov 2012 16:31:35 +0000 (18:31 +0200)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 6 Dec 2012 11:20:05 +0000 (11:20 +0000)
commit8a3a3f4a507d46b1c22c923733b172eebcf188f1
tree23a3c695bbd06548f6e1fad90e07e1421702c621
parentfbdd5353e2bcb6313f7abd0e0cfbf2854bfc924d
drm/i915/sdvo: clean up connectors on intel_sdvo_init() failures

commit d0ddfbd3d1346c1f481ec2289eef350cdba64b42 upstream.

Any failures in intel_sdvo_init() after the intel_sdvo_setup_output() call
left behind ghost connectors, attached (with a dangling pointer) to the
sdvo that has been cleaned up and freed. Properly destroy any connectors
attached to the encoder.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=46381
CC: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Tested-by: bjo@nord-west.org
[danvet: added a comment to explain why we need to clean up connectors
even when sdvo_output_setup fails.]
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/gpu/drm/i915/intel_sdvo.c