]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
USB: ehci: make debug port in-use detection functional again
authorJan Beulich <JBeulich@suse.com>
Wed, 19 Dec 2012 16:15:56 +0000 (16:15 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 17 Jan 2013 16:46:39 +0000 (08:46 -0800)
commit8a935b4ad29d83731572f0eb10f033fee45ae2e3
tree31743b2e1474a639cb28717fcd6a6851891f6884
parentb8038a41540e8bc559bff3f131989a0bcbc5905a
USB: ehci: make debug port in-use detection functional again

commit 75e1a2ae1f61ce1ae640410ba757bba84bd9fefe upstream.

Debug port in-use determination must be done before the controller gets
reset the first time, i.e. before the call to ehci_setup() as of commit
1a49e2ac9651df7349867a5cf44e2c83de1046af. That commit effectively
rendered commit 9fa5780beea1274d498a224822397100022da7d4 useless.

While moving that code around, also fix the BAR determination - the
respective capability field is a 3- rather than a 2-bit one -, and use
PCI_CAP_ID_DBG instead of the literal 0x0a.

It's unclear to me whether the debug port functionality is important
enough to warrant fixing this in stable kernels too.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/ehci-pci.c