]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
firmware: change kernel read fail to dev_dbg()
authorLuis R. Rodriguez <mcgrof@suse.com>
Sun, 28 Feb 2016 20:57:55 +0000 (21:57 +0100)
committerJames Morris <james.l.morris@oracle.com>
Mon, 29 Feb 2016 08:08:06 +0000 (19:08 +1100)
commit8e516aa52cea98b23e14c5d67fe74147e73d25f7
treea2c715ba85f879276ed37d0e7229064f6bdaaff8
parent2cb6d6460f1a171c71c134e0efe3a94c2206d080
firmware: change kernel read fail to dev_dbg()

When we now use the new kernel_read_file_from_path() we
are reporting a failure when we iterate over all the paths
possible for firmware. Before using kernel_read_file_from_path()
we only reported a failure once we confirmed a file existed
with filp_open() but failed with fw_read_file_contents().

With kernel_read_file_from_path() both are done for us and
we obviously are now reporting too much information given that
some optional paths will always fail and clutter the logs.

fw_get_filesystem_firmware() already has a check for failure
and uses an internal flag, FW_OPT_NO_WARN, but this does not
let us capture other unxpected errors. This enables that
as changed by Neil via commit:

"firmware: Be a bit more verbose about direct firmware loading failure"

Reported-by: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Neil Horman <nhorman@tuxdriver.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Mimi Zohar <zohar@linux.vnet.ibm.com>
Cc: Kees Cook <keescook@chromium.org>
Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
Acked-by: Kees Cook <keescook@chromium.org>
Acked-by: Ming Lei <ming.lei@canonical.com>
Signed-off-by: James Morris <james.l.morris@oracle.com>
drivers/base/firmware_class.c