]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
pwm-backlight: Fix bogus request for GPIO#0 when instantiated from DT
authorLothar Waßmann <LW@KARO-electronics.de>
Wed, 20 Aug 2014 06:38:36 +0000 (08:38 +0200)
committerLee Jones <lee.jones@linaro.org>
Wed, 20 Aug 2014 12:23:00 +0000 (13:23 +0100)
commit937222c4dda495277a8dfbc18bf7e54fe670105c
tree41fd4cc338bd4dd3136237df05e7414146c50516
parent7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9
pwm-backlight: Fix bogus request for GPIO#0 when instantiated from DT

commit 257462dbf3ed ("pwm-backlight: switch to gpiod interface")
introduced a regression leading to acquiring a bogus GPIO-0 when
configured from DT without an 'enable-gpios' property.
The driver will happily accept the 0 initialized 'enable_gpio' member
of the struct platform_pwm_backlight_data as valid gpio number, and
request this GPIO as enable pin. In case of multiple driver instances,
the second will fail to register with the error message:
pwm-backlight backlight1.23: failed to request GPIO#0: -16

Fix this by setting enable_gpio in the pdata struct to -EINVAL.

Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
Acked-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/video/backlight/pwm_bl.c