]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
net: packet: fix information leak to userland
authorVasiliy Kulikov <segooon@gmail.com>
Wed, 10 Nov 2010 20:09:10 +0000 (12:09 -0800)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 14 Apr 2011 23:53:46 +0000 (16:53 -0700)
commit975c07cc89c47f28bb83f2c7cc32a273c75add8a
treedfc5572a97ce1530e1f3f026ef15e47004345a66
parent1fe4497092df6c3a1f32bdd539ebd9747a289e85
net: packet: fix information leak to userland

commit 67286640f638f5ad41a946b9a3dc75327950248f upstream.

packet_getname_spkt() doesn't initialize all members of sa_data field of
sockaddr struct if strlen(dev->name) < 13.  This structure is then copied
to userland.  It leads to leaking of contents of kernel stack memory.
We have to fully fill sa_data with strncpy() instead of strlcpy().

The same with packet_getname(): it doesn't initialize sll_pkttype field of
sockaddr_ll.  Set it to zero.

Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Cc: Moritz Muehlenhoff <jmm@debian.org>
[jmm: Backported to 2.6.32]
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/packet/af_packet.c