]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
nvme: Fix nvme_get/set_features() with a NULL result pointer
authorAndy Lutomirski <luto@kernel.org>
Wed, 24 Aug 2016 10:52:12 +0000 (03:52 -0700)
committerJens Axboe <axboe@fb.com>
Wed, 24 Aug 2016 14:11:10 +0000 (08:11 -0600)
commit9b47f77a680447e0132b2cf7fb82374e014bec1c
tree378444caba4b1dd20784e870999ce67c1680997f
parente9e5e3fae8da7e237049e00e0bfc9e32fd808fe8
nvme: Fix nvme_get/set_features() with a NULL result pointer

nvme_set_features() callers seem to expect that passing NULL as the
result pointer is acceptable.  Teach nvme_set_features() not to try to
write to the NULL address.

For symmetry, make the same change to nvme_get_features(), despite the
fact that all current callers pass a valid result pointer.

I assume that this bug hasn't been reported in practice because
the callers that pass NULL are all in the SCSI translation layer
and no one uses the relevant operations.

Cc: stable@vger.kernel.org
Signed-off-by: Andy Lutomirski <luto@kernel.org>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Jens Axboe <axboe@fb.com>
drivers/nvme/host/core.c