]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
usb: musb: Stop bulk endpoint while queue is rotated
authorAndrew Goodbody <andrew.goodbody@cambrionix.com>
Tue, 31 May 2016 15:05:27 +0000 (10:05 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 11 Jul 2016 16:31:13 +0000 (09:31 -0700)
commita2cf3427dc3ff5bd3ef9d1afab6b45d76db2cf25
tree7660841a1f19c86c441f5ddd70934a26dbabb1f3
parent089a2d8400a63701ed271c03f6bf8b2d29bb5b98
usb: musb: Stop bulk endpoint while queue is rotated

commit 7b2c17f829545df27a910e8d82e133c21c9a8c9c upstream.

Ensure that the endpoint is stopped by clearing REQPKT before
clearing DATAERR_NAKTIMEOUT before rotating the queue on the
dedicated bulk endpoint.
This addresses an issue where a race could result in the endpoint
receiving data before it was reprogrammed resulting in a warning
about such data from musb_rx_reinit before it was thrown away.
The data thrown away was a valid packet that had been correctly
ACKed which meant the host and device got out of sync.

Signed-off-by: Andrew Goodbody <andrew.goodbody@cambrionix.com>
Signed-off-by: Bin Liu <b-liu@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/musb/musb_host.c