]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
iommu/arm-smmu: fix null-pointer dereference in arm_smmu_add_device
authorArtem Savkov <asavkov@redhat.com>
Tue, 8 Aug 2017 10:26:02 +0000 (12:26 +0200)
committerJoerg Roedel <jroedel@suse.de>
Fri, 11 Aug 2017 14:56:51 +0000 (16:56 +0200)
commita7990c647b35415e3dd07a077480a908678947ba
treee0a7f0065684f2aafa606291698d93b81cf525c1
parent74ddda71f44c84af62f736a77fb9fcebe5bb436a
iommu/arm-smmu: fix null-pointer dereference in arm_smmu_add_device

Commit c54451a "iommu/arm-smmu: Fix the error path in arm_smmu_add_device"
removed fwspec assignment in legacy_binding path as redundant which is
wrong. It needs to be updated after fwspec initialisation in
arm_smmu_register_legacy_master() as it is dereferenced later. Without
this there is a NULL-pointer dereference panic during boot on some hosts.

Signed-off-by: Artem Savkov <asavkov@redhat.com>
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
Acked-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/arm-smmu.c