]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
powerpc/smp: Remove migrate_irq() custom implementation
authorBenjamin Herrenschmidt <benh@kernel.crashing.org>
Wed, 5 Apr 2017 07:54:49 +0000 (17:54 +1000)
committerMichael Ellerman <mpe@ellerman.id.au>
Fri, 7 Apr 2017 02:01:27 +0000 (12:01 +1000)
commita978e13965a40ac07163643cc3fa0ddb0d354198
tree64f2eb659ce991062ff1a85949f14a11d1450ba3
parent14d4ae5c4cb89c05262fe41cb7a26f6ba949d8df
powerpc/smp: Remove migrate_irq() custom implementation

Some powerpc platforms use this to move IRQs away from a CPU being
unplugged. This function has several bugs such as not taking the right
locks or failing to NULL check pointers.

There's a new generic function doing exactly the same thing without all
the bugs, so let's use it instead.

mpe: The obvious place for the select of GENERIC_IRQ_MIGRATION is on
HOTPLUG_CPU, but that doesn't work. On some configs PM_SLEEP_SMP will
select HOTPLUG_CPU even though its dependencies are not met, which means
the select of GENERIC_IRQ_MIGRATION doesn't happen. That leads to the
build breaking. Fix it by moving the select of GENERIC_IRQ_MIGRATION to
SMP.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/include/asm/smp.h
arch/powerpc/kernel/irq.c
arch/powerpc/kernel/smp.c
arch/powerpc/platforms/Kconfig.cputype