]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
writeback: introduce .tagged_writepages for the WB_SYNC_NONE sync stage
authorWu Fengguang <fengguang.wu@intel.com>
Sun, 6 Jun 2010 16:38:15 +0000 (10:38 -0600)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 3 Oct 2011 18:40:43 +0000 (11:40 -0700)
commitac693061b11c33d5a5c5ec1925de7abd3fcb0971
tree968e4efb688a21caedd5a3e7baea3d6343abf4bd
parent0d39ea76fa3b9a97e9dc45282613bc239ffa8509
writeback: introduce .tagged_writepages for the WB_SYNC_NONE sync stage

commit 6e6938b6d3130305a5960c86b1a9b21e58cf6144 upstream.

sync(2) is performed in two stages: the WB_SYNC_NONE sync and the
WB_SYNC_ALL sync. Identify the first stage with .tagged_writepages and
do livelock prevention for it, too.

Jan's commit f446daaea9 ("mm: implement writeback livelock avoidance
using page tagging") is a partial fix in that it only fixed the
WB_SYNC_ALL phase livelock.

Although ext4 is tested to no longer livelock with commit f446daaea9,
it may due to some "redirty_tail() after pages_skipped" effect which
is by no means a guarantee for _all_ the file systems.

Note that writeback_inodes_sb() is called by not only sync(), they are
treated the same because the other callers also need livelock prevention.

Impact:  It changes the order in which pages/inodes are synced to disk.
Now in the WB_SYNC_NONE stage, it won't proceed to write the next inode
until finished with the current inode.

Acked-by: Jan Kara <jack@suse.cz>
CC: Dave Chinner <david@fromorbit.com>
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
fs/ext4/inode.c
fs/fs-writeback.c
include/linux/writeback.h
mm/page-writeback.c