]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
gpiolib: fix filtering out unwanted events
authorBartosz Golaszewski <brgl@bgdev.pl>
Fri, 23 Jun 2017 11:45:16 +0000 (13:45 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Thu, 29 Jun 2017 09:33:46 +0000 (11:33 +0200)
commitad537b822577fcc143325786cd6ad50d7b9df31c
tree0894a0efdc66032a12b792e2e40d0506732cde83
parentc0bc126f97fb929b3ae02c1c62322645d70eb408
gpiolib: fix filtering out unwanted events

GPIOEVENT_REQUEST_BOTH_EDGES is not a single flag, but a binary OR of
GPIOEVENT_REQUEST_RISING_EDGE and GPIOEVENT_REQUEST_FALLING_EDGE.

The expression 'le->eflags & GPIOEVENT_REQUEST_BOTH_EDGES' we'll get
evaluated to true even if only one event type was requested.

Fix it by checking both RISING & FALLING flags explicitly.

Cc: stable@vger.kernel.org
Fixes: 61f922db7221 ("gpio: userspace ABI for reading GPIO line events")
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpiolib.c