]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
bonding: require speed/duplex only for 802.3ad, alb and tlb
authorAndreas Born <futur.andy@googlemail.com>
Thu, 10 Aug 2017 04:41:44 +0000 (06:41 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 11 Aug 2017 21:21:42 +0000 (14:21 -0700)
commitad729bc9acfb7c47112964b4877ef5404578ed13
treeb714609403d7c5e210c2d4bc805dd3716c900584
parente71cb9e00922902ba0519f37d09145f117dc02b3
bonding: require speed/duplex only for 802.3ad, alb and tlb

The patch c4adfc822bf5 ("bonding: make speed, duplex setting consistent
with link state") puts the link state to down if
bond_update_speed_duplex() cannot retrieve speed and duplex settings.
Assumably the patch was written with 802.3ad mode in mind which relies
on link speed/duplex settings. For other modes like active-backup these
settings are not required. Thus, only for these other modes, this patch
reintroduces support for slaves that do not support reporting speed or
duplex such as wireless devices. This fixes the regression reported in
bug 196547 (https://bugzilla.kernel.org/show_bug.cgi?id=196547).

Fixes: c4adfc822bf5 ("bonding: make speed, duplex setting consistent
with link state")
Signed-off-by: Andreas Born <futur.andy@googlemail.com>
Acked-by: Mahesh Bandewar <maheshb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/bonding/bond_main.c
include/net/bonding.h