]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
printk: fix parsing of "brl=" option
authorNicolas Iooss <nicolas.iooss_linux@m4x.org>
Thu, 25 Aug 2016 22:17:00 +0000 (15:17 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sat, 27 Aug 2016 00:39:35 +0000 (17:39 -0700)
commitae6c33ba6e37eea3012fe2640b22400ef3f2d0f3
tree1b9b32d65ef7db7a0078f31a5f325bc108ba6dd2
parent804dd150468cfd920d92d4b3cf00536fedef3902
printk: fix parsing of "brl=" option

Commit bbeddf52adc1 ("printk: move braille console support into separate
braille.[ch] files") moved the parsing of braille-related options into
_braille_console_setup(), changing the type of variable str from char*
to char**.  In this commit, memcmp(str, "brl,", 4) was correctly updated
to memcmp(*str, "brl,", 4) but not memcmp(str, "brl=", 4).

Update the code to make "brl=" option work again and replace memcmp()
with strncmp() to make the compiler able to detect such an issue.

Fixes: bbeddf52adc1 ("printk: move braille console support into separate braille.[ch] files")
Link: http://lkml.kernel.org/r/20160823165700.28952-1-nicolas.iooss_linux@m4x.org
Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Cc: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
kernel/printk/braille.c