]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
IB/rxe: Update caller's CRC for RXE_MEM_TYPE_DMA memory type
authorLeon Romanovsky <leonro@mellanox.com>
Thu, 4 May 2017 12:36:07 +0000 (15:36 +0300)
committerDoug Ledford <dledford@redhat.com>
Thu, 4 May 2017 23:31:46 +0000 (19:31 -0400)
commitaf5df5fb59ee01e78fd334c3d6202d9e7bcfddd3
treebfae267ecd0f30f91bd9ba9828c07d7ff936c848
parent62239fc6e5545b2e59f83dfbc5db231a81f37a45
IB/rxe: Update caller's CRC for RXE_MEM_TYPE_DMA memory type

Callers of rxe_mem_copy() provide pointer to store updated CRC
value. That pointer was supposed to be updated, but the
commit cee2688e3cd6 ("IB/rxe: Offload CRC calculation when possible")
mistakenly removed that assignment for RXE_MEM_TYPE_DMA memory type.

The code worked because there are no actual callers with
RXE_MEM_TYPE_DMA, who are interested in returned value of crcp.
The one caller in read_reply(), who uses the returned crcp didn't
set RXE_MEM_TYPE_DMA as mem->type.

Fixes: cee2688e3cd6 ("IB/rxe: Offload CRC calculation when possible")
Reported-by: Andrew Boyer <andrew.boyer@dell.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Acked-by: Moni Shoua <monis@mellanox.com>
Reviewed-by: Andrew Boyer <andrew.boyer@dell.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Doug Ledford <dledford@redhat.com>
drivers/infiniband/sw/rxe/rxe_mr.c