]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
ARM: OMAP2+: OPP: Fix to ensure check of right oppdef after bad one
authorNishanth Menon <nm@ti.com>
Fri, 18 May 2012 17:26:19 +0000 (12:26 -0500)
committerKevin Hilman <khilman@ti.com>
Tue, 19 Jun 2012 22:23:29 +0000 (15:23 -0700)
commitb110547e586eb5825bc1d04aa9147bff83b57672
tree6547f2dea4af3251a647e391a3eeac65f54ecdd3
parent164e0cbf608214bddc4d28e2777f49e7b3a0f65c
ARM: OMAP2+: OPP: Fix to ensure check of right oppdef after bad one

Commit 9fa2df6b90786301b175e264f5fa9846aba81a65
(ARM: OMAP2+: OPP: allow OPP enumeration to continue if device is not present)
makes the logic:
for (i = 0; i < opp_def_size; i++) {
<snip>
if (!oh || !oh->od) {
<snip>
continue;
}
<snip>
opp_def++;
}

In short, the moment we hit a "Bad OPP", we end up looping the list
comparing against the bad opp definition pointer for the rest of the
iteration count. Instead, increment opp_def in the for loop itself
and allow continue to be used in code without much thought so that
we check the next set of OPP definition pointers :)

Cc: Steve Sakoman <steve@sakoman.com>
Cc: Tony Lindgren <tony@atomide.com>
Cc: stable@vger.kernel.org
Signed-off-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Kevin Hilman <khilman@ti.com>
arch/arm/mach-omap2/opp.c