]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
unix_diag: fix incorrect sign extension in unix_lookup_by_ino
authorDmitry V. Levin <ldv@altlinux.org>
Fri, 19 Feb 2016 01:27:48 +0000 (04:27 +0300)
committerDavid S. Miller <davem@davemloft.net>
Sat, 20 Feb 2016 04:49:23 +0000 (23:49 -0500)
commitb5f0549231ffb025337be5a625b0ff9f52b016f0
tree03efe8e30d488d9ef17671c578b2fcc07a96ffde
parent5a0e2f2622eb65b59bcefb01c5c475af4fab0e6d
unix_diag: fix incorrect sign extension in unix_lookup_by_ino

The value passed by unix_diag_get_exact to unix_lookup_by_ino has type
__u32, but unix_lookup_by_ino's argument ino has type int, which is not
a problem yet.
However, when ino is compared with sock_i_ino return value of type
unsigned long, ino is sign extended to signed long, and this results
to incorrect comparison on 64-bit architectures for inode numbers
greater than INT_MAX.

This bug was found by strace test suite.

Fixes: 5d3cae8bc39d ("unix_diag: Dumping exact socket core")
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/unix/diag.c