]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
clocksource: Make watchdog robust vs. interruption
authorThomas Gleixner <tglx@linutronix.de>
Thu, 16 Jun 2011 14:22:08 +0000 (16:22 +0200)
committerAndi Kleen <ak@linux.intel.com>
Mon, 1 Aug 2011 20:54:57 +0000 (13:54 -0700)
commitb679fa56258fbe656e5b2f9803fc9918bb703df3
treed3e1950ace2aefcb0343ee3f617aac485a9280e8
parente80440bb851ed3378b9855dd2bc9a3763eef48f1
clocksource: Make watchdog robust vs. interruption

commit b5199515c25cca622495eb9c6a8a1d275e775088 upstream.

The clocksource watchdog code is interruptible and it has been
observed that this can trigger false positives which disable the TSC.

The reason is that an interrupt storm or a long running interrupt
handler between the read of the watchdog source and the read of the
TSC brings the two far enough apart that the delta is larger than the
unstable treshold. Move both reads into a short interrupt disabled
region to avoid that.

Reported-and-tested-by: Vernon Mauery <vernux@us.ibm.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Andi Kleen <ak@linux.intel.com>
include/linux/clocksource.h
kernel/time/clocksource.c