]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
ASoC: pxa-ssp: atomically set stream active masks
authorDaniel Mack <zonque@gmail.com>
Mon, 19 Mar 2012 08:12:53 +0000 (09:12 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 2 Apr 2012 16:27:11 +0000 (09:27 -0700)
commitbb4b47099da04aa78ef6b351ef85574f7690780f
tree10dce64ccc90c6254d21fd447b14a5e9a994cd91
parentb113a5a2f7c1a153a49b388fd8695219207fe669
ASoC: pxa-ssp: atomically set stream active masks

commit 273b72c8ce6b28df6b49423d775c3e59072c73c5 upstream.

PXA's SSP engine fails to take its current channel phase into account
when enabling a stream while the engine is already running. This
results in randomly swapped left/right channels on either the record
or the playback side, depending on which one was enabled first.

The following patch fixes this by factoring out the bit field
modifications in question to a separate function that pauses the
engine temporarily, modifies the bits and kicks it off again
afterwards. Appearantly, a transition of SSCR0_SSE syncs both
directions properly.

The patch has been rolled out to quite a number of devices over the
last weeks and seems to fix the issue reliably.

Signed-off-by: Daniel Mack <zonque@gmail.com>
Reported-and-tested-by: Sven Neumann <s.neumann@raumfeld.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/soc/pxa/pxa-ssp.c