]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
scsi: qla2xxx: avoid unused-function warning
authorArnd Bergmann <arnd@arndb.de>
Fri, 30 Jun 2017 16:10:40 +0000 (18:10 +0200)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sat, 1 Jul 2017 21:14:58 +0000 (17:14 -0400)
commitbcda771b2f7e4f2a7577eef62ddeb61394e03b69
tree7e00b6f3ecae5cc993870656fc348199fe8d4584
parent9f80efda8f09283bb0fb7f8342a3e5c93857a7f2
scsi: qla2xxx: avoid unused-function warning

When NVMe support is disabled, we get a couple of harmless warnings:

drivers/scsi/qla2xxx/qla_nvme.c:667:13: error: 'qla_nvme_unregister_remote_port' defined but not used [-Werror=unused-function]
drivers/scsi/qla2xxx/qla_nvme.c:634:13: error: 'qla_nvme_abort_all' defined but not used [-Werror=unused-function]
drivers/scsi/qla2xxx/qla_nvme.c:604:12: error: 'qla_nvme_wait_on_rport_del' defined but not used [-Werror=unused-function]

This replaces the preprocessor checks in the code with equivalent
compiler conditionals, which lets gcc drop the unused functions without
warning, and is nicer to read.

Fixes: e84067d74301 ("scsi: qla2xxx: Add FC-NVMe F/W initialization and transport registration")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Himanshu Madhani <himanshu.madhani@cavium.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/Kconfig
drivers/scsi/qla2xxx/qla_nvme.c