]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
net: fix rds_iovec page count overflow
authorLinus Torvalds <torvalds@linux-foundation.org>
Thu, 28 Oct 2010 15:40:55 +0000 (15:40 +0000)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 14 Apr 2011 23:53:56 +0000 (16:53 -0700)
commitbd378dd6df5ca43021a49f72441a6c14d9784bed
treebadca281bb585a6bc66f411526b95f6b6b51da16
parentc18114efe9ae2bacb125f3273d004e5010d8cf07
net: fix rds_iovec page count overflow

commit 1b1f693d7ad6d193862dcb1118540a030c5e761f upstream.

As reported by Thomas Pollet, the rdma page counting can overflow.  We
get the rdma sizes in 64-bit unsigned entities, but then limit it to
UINT_MAX bytes and shift them down to pages (so with a possible "+1" for
an unaligned address).

So each individual page count fits comfortably in an 'unsigned int' (not
even close to overflowing into signed), but as they are added up, they
might end up resulting in a signed return value. Which would be wrong.

Catch the case of tot_pages turning negative, and return the appropriate
error code.

Reported-by: Thomas Pollet <thomas.pollet@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Andy Grover <andy.grover@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/rds/rdma.c