]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
drm/msm: gpu: call qcom_mdt interfaces only for ARCH_QCOM
authorArnd Bergmann <arnd@arndb.de>
Wed, 26 Jul 2017 15:52:44 +0000 (17:52 +0200)
committerRob Clark <robdclark@gmail.com>
Tue, 1 Aug 2017 23:25:51 +0000 (19:25 -0400)
commitbdab8e8b2bc89dce73b6bcabcd295806ce2e5ef9
tree943b95f2532699165813f96739e9dd82395c523d
parent541de4c9c953438b677c31072e7762115ac11299
drm/msm: gpu: call qcom_mdt interfaces only for ARCH_QCOM

When compile-testing for something other than ARCH_QCOM,
we run into a link error:

drivers/gpu/drm/msm/adreno/a5xx_gpu.o: In function `a5xx_hw_init':
a5xx_gpu.c:(.text.a5xx_hw_init+0x600): undefined reference to `qcom_mdt_get_size'
a5xx_gpu.c:(.text.a5xx_hw_init+0x93c): undefined reference to `qcom_mdt_load'

There is already an #ifdef that tries to check for CONFIG_QCOM_MDT_LOADER,
but that symbol is only meaningful when building for ARCH_QCOM.

This adds a compile-time check for ARCH_QCOM, and clarifies the
Kconfig select statement so we don't even try it for other targets.

The check for CONFIG_QCOM_MDT_LOADER can then go away, which also
improves compile-time coverage and makes the code a little nicer
to read.

Fixes: 7c65817e6d38 ("drm/msm: gpu: Enable zap shader for A5XX")
Acked-by: Jordan Crouse <jcrouse@codeaurora.org>
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Rob Clark <robdclark@gmail.com>
drivers/gpu/drm/msm/Kconfig
drivers/gpu/drm/msm/adreno/a5xx_gpu.c