]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
powerpc: Fix bad inline asm constraint in create_zero_mask()
authorAnton Blanchard <anton@samba.org>
Fri, 29 Apr 2016 22:29:27 +0000 (08:29 +1000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 11 May 2016 09:21:20 +0000 (11:21 +0200)
commitbeac678d0908ee0a14200e1412f98a89b765c0aa
tree7457c857d4a896702e5a00afe30fcdfa5f6ffe5a
parentee3e27f14e40bc3c95a175af482d6bbf35ab78bc
powerpc: Fix bad inline asm constraint in create_zero_mask()

commit b4c112114aab9aff5ed4568ca5e662bb02cdfe74 upstream.

In create_zero_mask() we have:

addi %1,%2,-1
andc %1,%1,%2
popcntd %0,%1

using the "r" constraint for %2. r0 is a valid register in the "r" set,
but addi X,r0,X turns it into an li:

li r7,-1
andc r7,r7,r0
popcntd r4,r7

Fix this by using the "b" constraint, for which r0 is not a valid
register.

This was found with a kernel build using gcc trunk, narrowed down to
when -frename-registers was enabled at -O2. It is just luck however
that we aren't seeing this on older toolchains.

Thanks to Segher for working with me to find this issue.

Fixes: d0cebfa650a0 ("powerpc: word-at-a-time optimization for 64-bit Little Endian")
Signed-off-by: Anton Blanchard <anton@samba.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/powerpc/include/asm/word-at-a-time.h