]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
fib_trie: leaf_walk_rcu should not compute key if key is less than pn->key
authorAlexander Duyck <aduyck@mirantis.com>
Tue, 27 Oct 2015 22:06:45 +0000 (15:06 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 28 Oct 2015 01:14:51 +0000 (18:14 -0700)
commitc2229fe1430d4e1c70e36520229dd64a87802b20
tree9d2f2cb4fd5a6af71b95b873d84cfdce13365ea5
parent8fe012964a39ead19405ba8d65f50d4fd598f5b8
fib_trie: leaf_walk_rcu should not compute key if key is less than pn->key

We were computing the child index in cases where the key value we were
looking for was actually less than the base key of the tnode.  As a result
we were getting incorrect index values that would cause us to skip over
some children.

To fix this I have added a test that will force us to use child index 0 if
the key we are looking for is less than the key of the current tnode.

Fixes: 8be33e955cb9 ("fib_trie: Fib walk rcu should take a tnode and key instead of a trie and a leaf")
Reported-by: Brian Rak <brak@gameservers.com>
Signed-off-by: Alexander Duyck <aduyck@mirantis.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/fib_trie.c