]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
leds-add-led-driver-for-lm3556-chip-checkpatch-fixes
authorAndrew Morton <akpm@linux-foundation.org>
Wed, 4 Apr 2012 00:08:30 +0000 (10:08 +1000)
committerStephen Rothwell <sfr@canb.auug.org.au>
Wed, 11 Apr 2012 04:45:53 +0000 (14:45 +1000)
commitc2a673abf5c57c00a777ea134fe7a31712d293d1
tree0cbf54ef10616a544e9894dad1b1f2dc5384d52a
parentf2671f3c85fd90da642f245eaa2823a7b410577f
leds-add-led-driver-for-lm3556-chip-checkpatch-fixes

WARNING: please write a paragraph that describes the config symbol fully
#31: FILE: drivers/leds/Kconfig:397:
+config LEDS_LM3556

ERROR: "foo * bar" should be "foo *bar"
#201: FILE: drivers/leds/leds-lm3556.c:143:
+int lm3556_read_reg(struct i2c_client *client, u8 reg, u8 * val)

WARNING: simple_strtoul is obsolete, use kstrtoul instead
#380: FILE: drivers/leds/leds-lm3556.c:322:
+ unsigned long state = simple_strtoul(buf, &after, 10);

total: 1 errors, 2 warnings, 727 lines checked

./patches/leds-add-led-driver-for-lm3556-chip.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

Cc: Axel Lin <axel.lin@gmail.com>
Cc: Daniel Jeong <daniel.jeong@ti.com>
Cc: Geon Si Jeong <gshark.jeong@gmail.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
drivers/leds/leds-lm3556.c