]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
smack: fix double free in smack_parse_opts_str()
authorTetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Fri, 24 Mar 2017 11:42:05 +0000 (20:42 +0900)
committerCasey Schaufler <casey@schaufler-ca.com>
Tue, 4 Apr 2017 22:41:15 +0000 (15:41 -0700)
commitc3c8dc9f13e2e13013822ee54a529a6fe284f1e1
tree77e0bfea1ec966eb0952765574b3b1fa56ecb84e
parente4e55b47ed9ae2c05ff062601ff6dacbe9dc4775
smack: fix double free in smack_parse_opts_str()

smack_parse_opts_str() calls kfree(opts->mnt_opts) when kcalloc() for
opts->mnt_opts_flags failed. But it should not have called it because
security_free_mnt_opts() will call kfree(opts->mnt_opts).

Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
fixes: 3bf2789cad9e6573 ("smack: allow mount opts setting over filesystems with binary mount data")
Cc: Vivek Trivedi <t.vivek@samsung.com>
Cc: Amit Sahrawat <a.sahrawat@samsung.com>
Cc: Casey Schaufler <casey@schaufler-ca.com>
security/smack/smack_lsm.c