]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
ip: ip_options_compile() resilient to NULL skb route
authorEric Dumazet <eric.dumazet@gmail.com>
Thu, 14 Apr 2011 05:55:37 +0000 (05:55 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 15 Apr 2011 06:26:02 +0000 (23:26 -0700)
commitc65353daf137dd41f3ede3baf62d561fca076228
tree407488cc052fff615d61c889100a76e057c1f203
parent49b4947aae404c8c5758ffd1007d0d78c48b3643
ip: ip_options_compile() resilient to NULL skb route

Scot Doyle demonstrated ip_options_compile() could be called with an skb
without an attached route, using a setup involving a bridge, netfilter,
and forged IP packets.

Let's make ip_options_compile() and ip_options_rcv_srr() a bit more
robust, instead of changing bridge/netfilter code.

With help from Hiroaki SHIMODA.

Reported-by: Scot Doyle <lkml@scotdoyle.com>
Tested-by: Scot Doyle <lkml@scotdoyle.com>
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Stephen Hemminger <shemminger@vyatta.com>
Acked-by: Hiroaki SHIMODA <shimoda.hiroaki@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/ip_options.c