]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
i2c: designware-baytrail: fix potential null pointer dereference on dev
authorColin Ian King <colin.king@canonical.com>
Mon, 20 Mar 2017 11:51:23 +0000 (11:51 +0000)
committerWolfram Sang <wsa@the-dreams.de>
Wed, 19 Apr 2017 19:00:13 +0000 (21:00 +0200)
commitc7f82ea8605627b3088f166d9f4a5ca7857e8383
tree237b2399914d3db7e9e268cb23b1a84ecdf90542
parentbd698d24b1b5790d0a22d44a0705dabd47235ad4
i2c: designware-baytrail: fix potential null pointer dereference on dev

The assignment to addr requires a call to get_sem_addr that dereferences
dev, however, this dereference occurs before a null pointer check on dev.
Move this assignment after the null check on dev to avoid a potential null
pointer dereference.

Detected by CoverityScan, CID#1419700 ("Dereference before null check")

Fixes: fd476fa22a1f432 ("i2c: designware-baytrail: Add support for cherrytrail")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
drivers/i2c/busses/i2c-designware-baytrail.c