]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
USB: fix use-after-free bug in usb_hcd_unlink_urb()
authorAlan Stern <stern@rowland.harvard.edu>
Fri, 30 Jan 2015 17:58:26 +0000 (12:58 -0500)
committerGreg Kroah-Hartman <greg@kroah.com>
Sat, 31 Jan 2015 17:05:06 +0000 (09:05 -0800)
commitc99197902da284b4b723451c1471c45b18537cde
treeff9d749b80d391ccc7b2dcd769c475facdeb9897
parentcefa9a31a5f0856b81d53030815485fcb1fe8aab
USB: fix use-after-free bug in usb_hcd_unlink_urb()

The usb_hcd_unlink_urb() routine in hcd.c contains two possible
use-after-free errors.  The dev_dbg() statement at the end of the
routine dereferences urb and urb->dev even though both structures may
have been deallocated.

This patch fixes the problem by storing urb->dev in a local variable
(avoiding the dereference of urb) and moving the dev_dbg() up before
the usb_put_dev() call.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Reported-by: Joe Lawrence <joe.lawrence@stratus.com>
Tested-by: Joe Lawrence <joe.lawrence@stratus.com>
CC: <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
drivers/usb/core/hcd.c