]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
ecryptfs: read on a directory should return EISDIR if not supported
authorAndy Whitcroft <apw@canonical.com>
Wed, 16 Feb 2011 04:49:59 +0000 (04:49 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 4 Mar 2012 17:49:21 +0000 (09:49 -0800)
commitcce3ac26c143a639332fc92f8d0105e2e9f2256c
tree6f94eabdd56248b9cd78949fe1275e8d0931ae34
parent2e1a2aa9a9969836243d634dfbf1631e7e63f53e
ecryptfs: read on a directory should return EISDIR if not supported

commit 323ef68faf1bbd9b1e66aea268fd09d358d7e8ab upstream.

read() calls against a file descriptor connected to a directory are
incorrectly returning EINVAL rather than EISDIR:

  [EISDIR]
    [XSI] [Option Start] The fildes argument refers to a directory and the
    implementation does not allow the directory to be read using read()
    or pread(). The readdir() function should be used instead. [Option End]

This occurs because we do not have a .read operation defined for
ecryptfs directories.  Connect this up to generic_read_dir().

BugLink: http://bugs.launchpad.net/bugs/719691
Signed-off-by: Andy Whitcroft <apw@canonical.com>
Signed-off-by: Tyler Hicks <tyhicks@linux.vnet.ibm.com>
fs/ecryptfs/file.c