]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
usb-storage: Accept 8020i-protocol commands longer than 12 bytes
authorAlan Stern <stern@rowland.harvard.edu>
Tue, 25 Oct 2011 14:50:58 +0000 (10:50 -0400)
committerGreg Kroah-Hartman <gregkh@suse.de>
Sat, 26 Nov 2011 17:08:38 +0000 (09:08 -0800)
commitce0e4cbdc4e962aefc25bde683c415e25ed45ee6
treefe22040e2261fb21b0d6ec50c45db25076e6cd23
parent4c72dfff8cfbc0d5c63145691c9dbbd1df995c1c
usb-storage: Accept 8020i-protocol commands longer than 12 bytes

commit 2f640bf4c94324aeaa1b6385c10aab8c5ad1e1cf upstream.

The 8020i protocol (also 8070i and QIC-157) uses 12-byte commands;
shorter commands must be padded.  Simon Detheridge reports that his
3-TB USB disk drive claims to use the 8020i protocol (which is
normally meant for ATAPI devices like CD drives), and because of its
large size, the disk drive requires the use of 16-byte commands.
However the usb_stor_pad12_command() routine in usb-storage always
sets the command length to 12, making the drive impossible to use.

Since the SFF-8020i specification allows for 16-byte commands in
future extensions, we may as well accept them.  This patch (as1490)
changes usb_stor_pad12_command() to leave commands larger than 12
bytes alone rather than truncating them.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Tested-by: Simon Detheridge <simon@widgit.com>
CC: Matthew Dharm <mdharm-usb@one-eyed-alien.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/storage/protocol.c