]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
libata: Align ata_device's id on a cacheline
authorHarvey Hunt <harvey.hunt@imgtec.com>
Wed, 24 Feb 2016 15:16:43 +0000 (15:16 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 9 Mar 2016 23:34:52 +0000 (15:34 -0800)
commitcea2cbff57c5b65375adb6fe65612c10a7301327
tree4d475cdd07c0ec72902d06530406f7e23c8a9ef6
parentb693f2ad0f7bf4b7080dc05da8d436eba8c47193
libata: Align ata_device's id on a cacheline

commit 4ee34ea3a12396f35b26d90a094c75db95080baa upstream.

The id buffer in ata_device is a DMA target, but it isn't explicitly
cacheline aligned. Due to this, adjacent fields can be overwritten with
stale data from memory on non coherent architectures. As a result, the
kernel is sometimes unable to communicate with an ATA device.

Fix this by ensuring that the id buffer is cacheline aligned.

This issue is similar to that fixed by Commit 84bda12af31f
("libata: align ap->sector_buf").

Signed-off-by: Harvey Hunt <harvey.hunt@imgtec.com>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/linux/libata.h