]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
net, wireless: overwrite default_ethtool_ops
authorStanislaw Gruszka <sgruszka@redhat.com>
Thu, 10 Jan 2013 23:19:10 +0000 (23:19 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 11 Jan 2013 23:55:48 +0000 (15:55 -0800)
commitd07d7507bfb4e23735c9b83e397c43e1e8a173e8
tree1422f8bc9cfa0340a7b1cdec03456a6bf5e3a7d5
parentf7e9e230f41f991a6e3e7cb6096424fdfb626081
net, wireless: overwrite default_ethtool_ops

Since:

commit 2c60db037034d27f8c636403355d52872da92f81
Author: Eric Dumazet <edumazet@google.com>
Date:   Sun Sep 16 09:17:26 2012 +0000

    net: provide a default dev->ethtool_ops

wireless core does not correctly assign ethtool_ops.

After alloc_netdev*() call, some cfg80211 drivers provide they own
ethtool_ops, but some do not. For them, wireless core provide generic
cfg80211_ethtool_ops, which is assigned in NETDEV_REGISTER notify call:

        if (!dev->ethtool_ops)
                dev->ethtool_ops = &cfg80211_ethtool_ops;

But after Eric's commit, dev->ethtool_ops is no longer NULL (on cfg80211
drivers without custom ethtool_ops), but points to &default_ethtool_ops.

In order to fix the problem, provide function which will overwrite
default_ethtool_ops and use it by wireless core.

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Acked-by: Johannes Berg <johannes@sipsolutions.net>
Acked-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/linux/netdevice.h
net/core/dev.c
net/wireless/core.c