]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
usb: ch9: fix up MaxStreams helper
authorFelipe Balbi <balbi@ti.com>
Mon, 2 Jan 2012 11:35:41 +0000 (13:35 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 12 Jan 2012 19:29:43 +0000 (11:29 -0800)
commitd2570fc048ca1307e64572c825e0d7908bd60a21
tree46414bec9de8f5858729c6930f7d88fc9f6e786f
parent5b511b783385bc68663e4729be7f169ce3061e6d
usb: ch9: fix up MaxStreams helper

commit 18b7ede5f7ee2092aedcb578d3ac30bd5d4fc23c upstream.

[ removed the dwc3 portion of the patch as it didn't apply to
older kernels - gregkh]

According to USB 3.0 Specification Table 9-22, if
bmAttributes [4:0] are set to zero, it means "no
streams supported", but the way this helper was
defined on Linux, we will *always* have one stream
which might cause several problems.

For example on DWC3, we would tell the controller
endpoint has streams enabled and yet start transfers
with Stream ID set to 0, which would goof up the host
side.

While doing that, convert the macro to an inline
function due to the different checks we now need.

Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/host/xhci.c
include/linux/usb/ch9.h