]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
x86/boot/32: Fix UP boot on Quark and possibly other platforms
authorAndy Lutomirski <luto@kernel.org>
Tue, 9 May 2017 00:09:10 +0000 (17:09 -0700)
committerIngo Molnar <mingo@kernel.org>
Tue, 9 May 2017 06:14:24 +0000 (08:14 +0200)
commitd2b6dc61a8dd3c429609b993778cb54e75a5c5f0
tree97e9ceeb4b2c54f18f212b79e38046e4fb5941a4
parent861ce4a3244c21b0af64f880d5bfe5e6e2fb9e4a
x86/boot/32: Fix UP boot on Quark and possibly other platforms

This partially reverts commit:

  23b2a4ddebdd17f ("x86/boot/32: Defer resyncing initial_page_table until per-cpu is set up")

That commit had one definite bug and one potential bug.  The
definite bug is that setup_per_cpu_areas() uses a differnet generic
implementation on UP kernels, so initial_page_table never got
resynced.  This was fine for access to percpu data (it's in the
identity map on UP), but it breaks other users of
initial_page_table.  The potential bug is that helpers like
efi_init() would be called before the tables were synced.

Avoid both problems by just syncing the page tables in setup_arch()
*and* setup_per_cpu_areas().

Reported-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Andy Lutomirski <luto@kernel.org>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Juergen Gross <jgross@suse.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Matt Fleming <matt@codeblueprint.co.uk>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Garnier <thgarnie@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-efi@vger.kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/kernel/setup.c
arch/x86/kernel/setup_percpu.c