]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
sched/fair: Test list head instead of list entry in throttle_cfs_rq()
authorCong Wang <xiyou.wangcong@gmail.com>
Wed, 24 Jun 2015 19:41:47 +0000 (12:41 -0700)
committerIngo Molnar <mingo@kernel.org>
Mon, 6 Jul 2015 12:15:08 +0000 (14:15 +0200)
commitd49db342f0e276b354383b3281c5668b6b80f5c2
tree646345871947652187cedb234ee08ffb2ef4974e
parent1c4c7159ed2468f3ac4ce5a7f08d79663d381a93
sched/fair: Test list head instead of list entry in throttle_cfs_rq()

According to the comments, we need to test if this is
the first throttled task, however, list_empty() tests on
the entry cfs_rq->throttled_list, not the head, this is wrong.

This is a bug because we don't re-init the list entry after
removing it from the list, so list_empty() could return false
even if the list is really empty.

Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: Cong Wang <cwang@twopensource.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Ben Segall <bsegall@google.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1435174907-432-1-git-send-email-xiyou.wangcong@gmail.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/sched/fair.c