]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
[PATCH] BLUETOOTH: Fix locking in hci_sock_dev_event().
authorSatyam Sharma <ssatyam@cse.iitk.ac.in>
Thu, 7 Jun 2007 06:02:16 +0000 (23:02 -0700)
committerChris Wright <chrisw@sous-sol.org>
Mon, 11 Jun 2007 18:36:54 +0000 (11:36 -0700)
commitd951c856912acfbb85eb33f59230c3019ef5dd55
tree504bca3dfe564fd37ab772dfc52e0d675bef2e5a
parent02a074766a0a8d1afd26f476b73422c08e34cbc8
[PATCH] BLUETOOTH: Fix locking in hci_sock_dev_event().

We presently use lock_sock() to acquire a lock on a socket in
hci_sock_dev_event(), but this goes BUG because lock_sock()
can sleep and we're already holding a read-write spinlock at
that point. So, we must use the non-sleeping BH version,
bh_lock_sock().

However, hci_sock_dev_event() is called from user context and
hence using simply bh_lock_sock() will deadlock against a
concurrent softirq that tries to acquire a lock on the same
socket. Hence, disabling BH's before acquiring the socket lock
and enable them afterwards, is the proper solution to fix
socket locking in hci_sock_dev_event().

Signed-off-by: Satyam Sharma <ssatyam@cse.iitk.ac.in>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/bluetooth/hci_sock.c