]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
tcp: tcp_get_info() should read tcp_time_stamp later
authorEric Dumazet <edumazet@google.com>
Thu, 16 Mar 2017 22:43:19 +0000 (15:43 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 17 Mar 2017 04:37:13 +0000 (21:37 -0700)
commitdb7f00b8dba6d687b6ab1f2e9309acfd214fcb4b
tree63eedb1bec5da3449c41e53e56fea4eee4f02c5e
parente14b4db7a567ff507453ecd9c64da51bbc2b6d23
tcp: tcp_get_info() should read tcp_time_stamp later

Commit b369e7fd41f7 ("tcp: make TCP_INFO more consistent") moved
lock_sock_fast() earlier in tcp_get_info()

This has the minor effect that jiffies value being sampled at the
beginning of tcp_get_info() is more likely to be off by one, and we
report big tcpi_last_data_sent values (like 0xFFFFFFFF).

Since we lock the socket, fetching tcp_time_stamp right before
doing the jiffies_to_msecs() calls is enough to remove these
wrong values.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp.c