]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
pids: make task_tgid_nr_ns() safe
authorOleg Nesterov <oleg@redhat.com>
Mon, 21 Aug 2017 15:35:02 +0000 (17:35 +0200)
committerLinus Torvalds <torvalds@linux-foundation.org>
Mon, 21 Aug 2017 19:47:31 +0000 (12:47 -0700)
commitdd1c1f2f2028a7b851f701fc6a8ebe39dcb95e7c
tree96b5e5466504cc8c88b0f0435e80f70f0c627c58
parent14ccee78fc82f5512908f4424f541549a5705b89
pids: make task_tgid_nr_ns() safe

This was reported many times, and this was even mentioned in commit
52ee2dfdd4f5 ("pids: refactor vnr/nr_ns helpers to make them safe") but
somehow nobody bothered to fix the obvious problem: task_tgid_nr_ns() is
not safe because task->group_leader points to nowhere after the exiting
task passes exit_notify(), rcu_read_lock() can not help.

We really need to change __unhash_process() to nullify group_leader,
parent, and real_parent, but this needs some cleanups.  Until then we
can turn task_tgid_nr_ns() into another user of __task_pid_nr_ns() and
fix the problem.

Reported-by: Troy Kensinger <tkensinger@google.com>
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
include/linux/pid.h
include/linux/sched.h
kernel/pid.c