]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
ipvs: fix inability to remove a mixed-family RS
authorAlexey Andriyanov <alan@al-an.info>
Fri, 6 Feb 2015 19:32:20 +0000 (22:32 +0300)
committerSimon Horman <horms@verge.net.au>
Mon, 9 Feb 2015 05:13:30 +0000 (14:13 +0900)
commitdd3733b3e798daf778a1ec08557f388f00fdc2f6
treea3a11a916d66b1b0435b51073540dfddbe3692de
parent42b5212fee4f57907e9415b18fe19c13e65574bc
ipvs: fix inability to remove a mixed-family RS

The current code prevents any operation with a mixed-family dest
unless IP_VS_CONN_F_TUNNEL flag is set. The problem is that it's impossible
for the client to follow this rule, because ip_vs_genl_parse_dest does
not even read the destination conn_flags when cmd = IPVS_CMD_DEL_DEST
(need_full_dest = 0).

Also, not every client can pass this flag when removing a dest. ipvsadm,
for example, does not support the "-i" command line option together with
the "-d" option.

This change disables any checks for mixed-family on IPVS_CMD_DEL_DEST command.

Signed-off-by: Alexey Andriyanov <alan@al-an.info>
Fixes: bc18d37f676f ("ipvs: Allow heterogeneous pools now that we support them")
Acked-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>
net/netfilter/ipvs/ip_vs_ctl.c