]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
IPoIB: Disable NAPI while CQ is being drained
authorYossi Etigin <yosefe@voltaire.com>
Mon, 20 Apr 2009 20:58:08 +0000 (13:58 -0700)
committerRoland Dreier <rolandd@cisco.com>
Mon, 20 Apr 2009 20:58:08 +0000 (13:58 -0700)
commite028cc55cc5c90a1c57eefe560a0cbb4df1fed14
treeb1ef203c107a4589536a089737ae550e0b18451b
parenta939b96cccdb65df80a52447ec8e4a6d79c56dbb
IPoIB: Disable NAPI while CQ is being drained

If NAPI is enabled while IPoIB's CQ is being drained, it creates a
race on priv->ibwc between ipoib_poll() and ipoib_drain_cq(), leading
to memory corruption.

The solution is to enable/disable NAPI in ipoib_ib_dev_{open/stop}()
instead of in ipoib_{open/stop}(), and sync NAPI on the INITIALIZED
flag instead on the ADMIN_UP flag. This way NAPI will be disabled when
ipoib_drain_cq() is called.

This fixes <https://bugs.openfabrics.org/show_bug.cgi?id=1587>.

Signed-off-by: Yossi Etigin <yosefe@voltaire.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
drivers/infiniband/ulp/ipoib/ipoib_ib.c
drivers/infiniband/ulp/ipoib/ipoib_main.c