]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
[PATCH] fill_tgid: fix task_struct leak and possible oops
authorOleg Nesterov <oleg@tv-sign.ru>
Sat, 28 Oct 2006 17:38:49 +0000 (10:38 -0700)
committerChris Wright <chrisw@sous-sol.org>
Sat, 4 Nov 2006 01:33:50 +0000 (17:33 -0800)
commite17f8851e194c759c35e058d9692e81a3eec8a1e
tree308514d3cb389ee235360ac35d22d275768871aa
parent1406fd4e987bd05a22827e8f0aa01f3335550e01
[PATCH] fill_tgid: fix task_struct leak and possible oops

1. fill_tgid() forgets to do put_task_struct(first).

2. release_task(first) can happen after fill_tgid() drops tasklist_lock,
   it is unsafe to dereference first->signal.

This is a temporary fix, imho the locking should be reworked.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Shailabh Nagar <nagar@watson.ibm.com>
Cc: Balbir Singh <balbir@in.ibm.com>
Cc: Jay Lan <jlan@sgi.com>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
kernel/taskstats.c