]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
fuse: reject O_DIRECT flag also in fuse_create
authorCsaba Henk <csaba@gluster.com>
Fri, 27 Nov 2009 14:00:14 +0000 (19:30 +0530)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 8 Dec 2009 19:17:19 +0000 (11:17 -0800)
commite192c2e5db689c874f6e56166face8ac96544350
tree17c633277d6c121bdf16c3fd2d3b585edd9e9e2b
parentfdab80d867f4df236d5158a232275147964a7705
fuse: reject O_DIRECT flag also in fuse_create

commit 1b7323965a8c6eee9dc4e345a7ae4bff1dc93149 upstream.

The comment in fuse_open about O_DIRECT:

  "VFS checks this, but only _after_ ->open()"

also holds for fuse_create, however, the same kind of check was missing there.

As an impact of this bug, open(newfile, O_RDWR|O_CREAT|O_DIRECT) fails, but a
stub newfile will remain if the fuse server handled the implied FUSE_CREATE
request appropriately.

Other impact: in the above situation ima_file_free() will complain to open/free
imbalance if CONFIG_IMA is set.

Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
Cc: Harshavardhana <harsha@gluster.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
fs/fuse/dir.c