]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
net: socket: don't set sk_uid to garbage value in ->setattr()
authorEric Biggers <ebiggers@google.com>
Fri, 30 Dec 2016 23:42:32 +0000 (17:42 -0600)
committerDavid S. Miller <davem@davemloft.net>
Sun, 1 Jan 2017 16:53:34 +0000 (11:53 -0500)
commite1a3a60a2ebe991605acb14cd58e39c0545e174e
treeb71f15a1e819cb409b2ccb665aae1a4e32fb399d
parentf5a0aab84b74de68523599817569c057c7ac1622
net: socket: don't set sk_uid to garbage value in ->setattr()

->setattr() was recently implemented for socket files to sync the socket
inode's uid to the new 'sk_uid' member of struct sock.  It does this by
copying over the ia_uid member of struct iattr.  However, ia_uid is
actually only valid when ATTR_UID is set in ia_valid, indicating that
the uid is being changed, e.g. by chown.  Other metadata operations such
as chmod or utimes leave ia_uid uninitialized.  Therefore, sk_uid could
be set to a "garbage" value from the stack.

Fix this by only copying the uid over when ATTR_UID is set.

Fixes: 86741ec25462 ("net: core: Add a UID field to struct sock.")
Signed-off-by: Eric Biggers <ebiggers@google.com>
Tested-by: Lorenzo Colitti <lorenzo@google.com>
Acked-by: Lorenzo Colitti <lorenzo@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/socket.c