]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
iommu/arm-smmu: Fix group refcounting
authorRobin Murphy <robin.murphy@arm.com>
Fri, 11 Nov 2016 17:59:22 +0000 (17:59 +0000)
committerJoerg Roedel <jroedel@suse.de>
Tue, 15 Nov 2016 11:25:33 +0000 (12:25 +0100)
commite1b44cbe7b5d4d97e43a1476b68e0adc1aa5e383
tree7c283d38914e753d1d65563c9101c2073282b8e8
parent13f59a78c6d69a9bf4c8989dd5f3396f54a2fe41
iommu/arm-smmu: Fix group refcounting

When arm_smmu_device_group() finds an existing group due to Stream ID
aliasing, it should be taking an additional reference on that group.
Otherwise, the caller of iommu_group_get_for_dev() will inadvertently
remove the reference taken by iommu_group_add_device(), and the group
will be freed prematurely if any device is removed.

Reported-by: Sricharan R <sricharan@codeaurora.org>
Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/arm-smmu.c