]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
saa7134: fix thread shutdown handling
authorJeff Mahoney <jeffm@suse.com>
Wed, 27 Jun 2007 21:09:58 +0000 (14:09 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Sat, 4 Aug 2007 16:10:25 +0000 (09:10 -0700)
commite278ed8f82fd26097a2ed8772c1211f6c5865ce1
treeeb6aacbf408920bff8ed065176b8d9fbf852e356
parent19210a2049713f5d5ea826ecf053ca671aeb53c7
saa7134: fix thread shutdown handling

This patch changes the test for the thread pid from >= 0 to > 0.

When the saa7134 driver initialization fails after a certain point, it goes
through the complete shutdown process for the driver.  Part of shutting it
down includes tearing down the thread for tv audio.

The test for tearing down the thread tests for >= 0.  Since the dev
structure is kzalloc'd, the test will always be true if we haven't tried to
start the thread yet.  We end up waiting on pid 0 to complete, which will
never happen, so we lock up.

This bug was observed in Novell Bugzilla 284718, when request_irq() failed.

Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Acked-by: Mauro Carvalho Chehab <mchehab@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/media/video/saa7134/saa7134-tvaudio.c