]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
iscsi-target: fix memory leak in iscsit_setup_text_cmd()
authorVarun Prakash <varun@chelsio.com>
Sun, 23 Jul 2017 14:33:33 +0000 (20:03 +0530)
committerNicholas Bellinger <nab@linux-iscsi.org>
Sun, 30 Jul 2017 22:31:34 +0000 (15:31 -0700)
commitea8dc5b4cd2195ee582cae28afa4164c6dea1738
tree55b2a54d2ccb2213d5cf633306b7ccf9fd8dfda6
parent66b59f9b1f41ee61eb4862bbcfc1e7db5298ba9e
iscsi-target: fix memory leak in iscsit_setup_text_cmd()

On receiving text request iscsi-target allocates buffer for
payload in iscsit_handle_text_cmd() and assigns buffer pointer
to cmd->text_in_ptr, this buffer is currently freed in
iscsit_release_cmd(), if iscsi-target sets 'C' bit in text
response then it will receive another text request from the
initiator with ttt != 0xffffffff in this case iscsi-target
will find cmd using itt and call iscsit_setup_text_cmd()
which will set cmd->text_in_ptr to NULL without freeing
previously allocated buffer.

This patch fixes this issue by calling kfree(cmd->text_in_ptr)
in iscsit_setup_text_cmd() before assigning NULL to it.

For the first text request cmd->text_in_ptr is NULL as
cmd is memset to 0 in iscsit_allocate_cmd().

Signed-off-by: Varun Prakash <varun@chelsio.com>
Cc: <stable@vger.kernel.org> # 4.0+
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/iscsi/iscsi_target.c