]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
x86/ldt: Fix off by one in get_segment_base()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 18 Aug 2017 10:30:30 +0000 (13:30 +0300)
committerIngo Molnar <mingo@kernel.org>
Tue, 29 Aug 2017 09:55:15 +0000 (11:55 +0200)
commiteaa2f87c6b840b83827c40db6eb8481689570259
tree93449daec7e592149122d621150d06cb79ef6baf
parent9c3a815f471a84811cf8021cf64aae3b8081dfde
x86/ldt: Fix off by one in get_segment_base()

ldt->entries[] is allocated in alloc_ldt_struct().  It has
ldt->nr_entries elements and ldt->nr_entries is capped at LDT_ENTRIES.
So if "idx" is == ldt->nr_entries then we're reading beyond the end of
the buffer.  It seems duplicative to have two limit checks when one
would work just as well so I removed the check against LDT_ENTRIES.

The gdt_page.gdt[] array has GDT_ENTRIES entries.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Andy Lutomirski <luto@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: kernel-janitors@vger.kernel.org
Fixes: d07bdfd322d3 ("perf/x86: Fix USER/KERNEL tagging of samples properly")
Link: http://lkml.kernel.org/r/20170818102516.gqwm4xdvvuvjw5ho@mwanda
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/events/core.c