]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
IPsec: do not ignore crypto err in ah4 input
authorGilad Ben-Yossef <gilad@benyossef.com>
Mon, 16 Jan 2017 11:17:55 +0000 (13:17 +0200)
committerSteffen Klassert <steffen.klassert@secunet.com>
Mon, 16 Jan 2017 11:57:48 +0000 (12:57 +0100)
commitebd89a2d0675f1325c2be5b7576fd8cb7e8defd0
tree5f9baea38a77a5970ef807e70b3e39cd617382b3
parent3819a35fdb8f82428c2b5190f195c4e0b8c427bf
IPsec: do not ignore crypto err in ah4 input

ah4 input processing uses the asynchronous hash crypto API which
supplies an error code as part of the operation completion but
the error code was being ignored.

Treat a crypto API error indication as a verification failure.

While a crypto API reported error would almost certainly result
in a memcpy of the digest failing anyway and thus the security
risk seems minor, performing a memory compare on what might be
uninitialized memory is wrong.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
net/ipv4/ah4.c