]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
Input: keyboard, serio - simplify use of devm_ioremap_resource
authorJulia Lawall <Julia.Lawall@lip6.fr>
Thu, 15 Aug 2013 07:08:17 +0000 (00:08 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Thu, 15 Aug 2013 07:30:17 +0000 (00:30 -0700)
commitef0aca7f2f94a24d82aea0b74ae7a71c611e4895
tree4079e6de6f11c7774cd652d98508207ff0f59990
parenteacd0c47966b918f10c7ac1a91dd9fccb0f58ddd
Input: keyboard, serio - simplify use of devm_ioremap_resource

Remove unneeded error handling on the result of a call to
platform_get_resource when the value is passed to devm_ioremap_resource.

Move the call to platform_get_resource adjacent to the call to
devm_ioremap_resource to make the connection between them more clear.

A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression pdev,res,n,e,e1;
expression ret != 0;
identifier l;
@@

- res = platform_get_resource(pdev, IORESOURCE_MEM, n);
  ... when != res
- if (res == NULL) { ... \(goto l;\|return ret;\) }
  ... when != res
+ res = platform_get_resource(pdev, IORESOURCE_MEM, n);
  e = devm_ioremap_resource(e1, res);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/keyboard/imx_keypad.c
drivers/input/keyboard/nspire-keypad.c
drivers/input/keyboard/spear-keyboard.c
drivers/input/serio/arc_ps2.c
drivers/input/serio/olpc_apsp.c